Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add resize-observer typs #847

Merged
merged 2 commits into from
Dec 12, 2020
Merged

feat: add resize-observer typs #847

merged 2 commits into from
Dec 12, 2020

Conversation

manucorporat
Copy link
Contributor

@manucorporat manucorporat commented Apr 9, 2020 •
edited
Loading

However, i got an error when generating the types for Resize Observer:

  bareMessage: 'Attributes cannot accept sequence types',
  context: 'Syntax error at line 23, since `interface ResizeObserverEntry`:\n' +
    ' attribute sequence<ResizeObserverSize> borderBoxSize;\n' +

fixes microsoft/TypeScript#37861

@msftclas
Copy link

msftclas commented Apr 9, 2020

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ manucorporat sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@willstott101
Copy link

Can you try again? Looks like those attributes should be FrozenArray not sequence as of w3c/csswg-drafts@f1c5335

@abdonrd
Copy link

abdonrd commented Jun 12, 2020

Any news here? Thanks in advance!

@mdingena
Copy link

mdingena commented Jul 6, 2020

@manucorporat Seems the build still fails at the sequence on line 23 and onwards.

https://github.com/microsoft/TSJS-lib-generator/blob/3ed06f51876b4f843c716eaf21bbf87d600e54f8/inputfiles/idl/Resize%20Observer.widl#L23-L25

https://github.com/microsoft/TSJS-lib-generator/blob/3ed06f51876b4f843c716eaf21bbf87d600e54f8/inputfiles/idl/Resize%20Observer.widl#L38

Should these be FrozenArray as well?

PS: Glad to see you're back on it. Hope these difficult times aren't treating you too harshly. I'm very much looking forward to seeing this progressing. Take care!

@ddprrt
Copy link

ddprrt commented Jul 16, 2020

There is already an update at https://drafts.csswg.org/resize-observer/ that changes sequence to FrozenArray everywhere. Don't know when this appears at the public Working Draft's page

@sapkra sapkra mentioned this pull request Oct 13, 2020
Closed
5 tasks
@MatthiasKunnen MatthiasKunnen mentioned this pull request Oct 13, 2020
Closed
@MatthiasKunnen
Copy link
Contributor

Also closes #908.

@timocov timocov mentioned this pull request Oct 26, 2020
Merged
@TiagoPortfolio
Copy link

Hi all! 👋

Thank you so much in advance for adding types for ResizeObserver!
Can I ask why is this taking so long to be reviewed? The last commit was in July.

Cheers!

@anandtiwary
Copy link

Any update please?

@timocov
Copy link
Contributor

timocov commented Nov 7, 2020

I have finished this PR some time ago since it's inactive from its author, see #948.

@orta orta merged commit dfae872 into microsoft:master Dec 12, 2020
@alexasselin008 alexasselin008 mentioned this pull request Feb 6, 2021
Merged
@MSiddharthReddy MSiddharthReddy mentioned this pull request Mar 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trybeanz Trybeanz Trybeanz approved these changes

@sandersn sandersn Awaiting requested review from sandersn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ResizeObserver API declarations missing